Enable Batch Sorted Merge for nullable order by with firstlast index - #9961
Merged
natalya-aksman merged 1 commit intoJun 11, 2026
Merged
Conversation
|
@svenklemm, @antekresic: please review this pull request.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Poroma-Banerjee
approved these changes
Jun 3, 2026
akuzm
approved these changes
Jun 11, 2026
natalya-aksman
force-pushed
the
support_batch_sorted_merge_on_nullable_orderby_with_firstlast
branch
from
June 11, 2026 15:37
28bdab5 to
7c184e4
Compare
akuzm
reviewed
Jun 11, 2026
| /* starting_pathkey_offset = */ 0, | ||
| compression_info, | ||
| /* for_bsm = */ true, | ||
| /* for_batch_sorted_merge = */ true, |
Member
There was a problem hiding this comment.
Just as a note for the future, I hope we can make the meaning of this more explicit. As far as I can understand, for full compressed sort pushdown the requirement is: "compressed sort leads to all batch rows beign fully sorted in required order", and for batch sorted merge it is: "compressed sort leads to first batch rows being sorted in required order"
Member
There was a problem hiding this comment.
And the "all rows sorted" condition is basically the "first row sorted" condition + "batches are not overlapping".
natalya-aksman
deleted the
support_batch_sorted_merge_on_nullable_orderby_with_firstlast
branch
June 11, 2026 16:23
kpan2034
pushed a commit
to kpan2034/timescaledb
that referenced
this pull request
Jul 1, 2026
…imescale#9961) We can now support Batch Sorted Merge for nullable order by columns with firstlast index as [timescale#9784](timescale#9784) have been implemented. We forbade Batch Sorted Merge for nullable order by columns with minmax index in timescale#9482. Now that firstlast index is available we can allow it for columns with firstlast index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can now support Batch Sorted Merge for nullable order by columns with firstlast index as #9784 have been implemented.
We forbade Batch Sorted Merge for nullable order by columns with minmax index in #9482. Now that firstlast index is available we can allow it for columns with firstlast index.
Disable-check: force-changelog-file